Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Stringified
converters to allow them being used on non-nullable types.As, for example,
Nullable<int>
andint
are distinct types, STJ refused to work with theStringifiedInt<int?>
converter if used on a simpleint
property.STJ does not invoke custom converters for
null
values unless the converter opts-in by returningtrue
in theHandleNull
method. As we don't do this, we don't have to care aboutnull
in the converter itself.Handling e.g. just
int
instead ofint?
in the stringified converter, allows us to annotateint
andint?
properties correctly without having to introduce another converter type.Closes #7870