Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump apm-perf in systemtest and tools #15379

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

carsonip
Copy link
Member

Motivation/summary

apm-server tools is using an outdated version of apm-perf that does not
enable rewrite-timestamps and rewrite-ids in apmbench. Bump apm-perf
dependency to enable rewrite-timestamps and rewrite-ids. Not rewriting
ids is causing TBS to reuse trace ids and only output a subset of
events.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

…default

apm-server tools is using an outdated version of apm-perf that does not
enable rewrite-timestamps and rewrite-ids in apmbench. Bump apm-perf
dependency to enable rewrite-timestamps and rewrite-ids. Not rewriting
ids is causing TBS to reuse trace ids and only output a subset of
events.
@carsonip carsonip requested a review from a team as a code owner January 25, 2025 21:15
Copy link
Contributor

mergify bot commented Jan 25, 2025

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Jan 25, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 25, 2025
@carsonip carsonip changed the title Bump apm-perf to make apmbench rewrite-timestamps and rewrite-ids by default Make apmbench rewrite-timestamps and rewrite-ids by default Jan 25, 2025
@carsonip carsonip changed the title Make apmbench rewrite-timestamps and rewrite-ids by default [apmbench] Enable rewrite-timestamps and rewrite-ids by default Jan 25, 2025
@carsonip carsonip marked this pull request as draft January 25, 2025 22:13
@carsonip carsonip changed the title [apmbench] Enable rewrite-timestamps and rewrite-ids by default Bump apm-perf in systemtest and tools Jan 25, 2025
@carsonip
Copy link
Member Author

No urgency to this as #15380 is merged

Copy link
Contributor

mergify bot commented Jan 28, 2025

This pull request is now in conflicts. Could you fix it @carsonip? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b bump-apm-perf upstream/bump-apm-perf
git merge upstream/main
git push upstream bump-apm-perf

@carsonip
Copy link
Member Author

This will fail CI as new apm-perf moved loadgen into an internal package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants