Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add example for payload filtering using callback #1445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ammaar8
Copy link

@ammaar8 ammaar8 commented Mar 15, 2024

What does this pull request do?

This PR adds an example using a callback for filtering to showcase how to use a filter to ignore some payloads completely. Currently, there is no example on how to do this in the docs.

Also I haven't been able to check on 4.x but on 3.x If you try to return nil in the block it spams the logs with Failed converting event to JSON: logs.

Why is it important?

This provides an example for users like me looking to filter out some payloads completely. Also uses an example that would be popular with Rails users since the redis spans are a nuisance.

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch

- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

  • I have made corresponding changes to the documentation

- [ ] I have updated CHANGELOG.asciidoc
- [ ] I have updated supported-technologies.asciidoc
- [ ] Added an API method or config option? Document in which version this will be introduced

Copy link

cla-checker-service bot commented Mar 15, 2024

💚 CLA has been signed

Added an example using a callback for filtering to showcase how to use a filter to ignore some payloads completely.

docs
@ammaar8 ammaar8 force-pushed the docs_add_filtering_example branch from 81500f2 to d76dfae Compare March 15, 2024 14:53
@ammaar8 ammaar8 changed the title [docs] Add example for payload filtering using callbcak [docs] Add example for payload filtering using callback Mar 15, 2024
@ammaar8 ammaar8 marked this pull request as ready for review March 15, 2024 14:54
@ammaar8 ammaar8 changed the title [docs] Add example for payload filtering using callback docs: Add example for payload filtering using callback Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant