-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added capturing s3 otel attributes from lamba S3Event #3364
added capturing s3 otel attributes from lamba S3Event #3364
Conversation
👋 @videnkz Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
💚 CLA has been signed |
8de303a
to
6bb3cf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor suggestions, thanks for implementing this!
...wslambda-plugin/src/main/java/co/elastic/apm/agent/awslambda/helper/S3TransactionHelper.java
Outdated
Show resolved
Hide resolved
...wslambda-plugin/src/main/java/co/elastic/apm/agent/awslambda/helper/S3TransactionHelper.java
Outdated
Show resolved
Hide resolved
04baefd
to
4814585
Compare
run elasticsearch-ci/docs |
* 'main' of https://github.com/elastic/apm-agent-java: (35 commits) buildkite: opentelemetry+elastic agent overhead benchmark on a weekly basis (elastic#3371) ci(action): remove unrequired action (elastic#3387) Bump org.springframework.boot:spring-boot-dependencies from 2.7.16 to 3.1.5 (elastic#3380) ci(action): archive benchmarks.jar (elastic#3386) remove noise (elastic#3385) Process otel benchmark (elastic#3384) Update tests for Jedis 5 (elastic#3382) added entry to community plugins (elastic#3383) added capturing s3 otel attributes from lamba S3Event (elastic#3364) Bump version.log4j from 2.12.4 to 2.21.0 (elastic#3366) Fix aws sdk instrumentation (elastic#3373) action: remove leftover from Jenkins (elastic#3368) Bump org.apache.logging.log4j:log4j-bom from 2.20.0 to 2.21.0 (elastic#3367) Bump io.micrometer:micrometer-core from 1.11.4 to 1.11.5 (elastic#3360) Add guard against invalid end timestamps (elastic#3363) Added otel to dependabot config, upgraded dependencies (elastic#3359) Bump version.byte-buddy from 1.14.8 to 1.14.9 (elastic#3361) Fix off-by-one error in tests which effectively disabled recycling validation (elastic#3357) Fix multiple spans being created for HTTPUrlConnection HEAD requests (elastic#3353) Bump org.ow2.asm:asm-tree from 9.5 to 9.6 (elastic#3349) ...
What does this PR do?
closes #3126
Added capturing of
aws.s3.bucket
andaws.s3.key
attributes fromS3Event
Checklist
Added an API method or config option? Document in which version this will be introducedI have made corresponding changes to the documentation