Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added capturing s3 otel attributes from lamba S3Event #3364

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

videnkz
Copy link
Contributor

@videnkz videnkz commented Oct 17, 2023

What does this PR do?

closes #3126
Added capturing of aws.s3.bucket and aws.s3.key attributes from S3Event

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Oct 17, 2023
@github-actions
Copy link

👋 @videnkz Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@cla-checker-service
Copy link

cla-checker-service bot commented Oct 17, 2023

💚 CLA has been signed

@videnkz videnkz force-pushed the add-otel-attributes-from-s3-event branch from 8de303a to 6bb3cf2 Compare October 17, 2023 15:16
Copy link
Contributor

@JonasKunz JonasKunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions, thanks for implementing this!

@videnkz videnkz force-pushed the add-otel-attributes-from-s3-event branch from 04baefd to 4814585 Compare October 24, 2023 08:01
@JonasKunz
Copy link
Contributor

run elasticsearch-ci/docs

@mergify mergify bot merged commit 5fcba10 into elastic:main Oct 24, 2023
18 checks passed
v1v added a commit that referenced this pull request Oct 26, 2023
…chmark-otel-in-buildkite

* upstream/main:
  Process otel benchmark (#3384)
  Update tests for Jedis 5 (#3382)
  added entry to community plugins (#3383)
  added capturing s3 otel attributes from lamba S3Event (#3364)
  Bump version.log4j from 2.12.4 to 2.21.0 (#3366)
  Fix aws sdk instrumentation (#3373)
v1v added a commit to v1v/apm-agent-java that referenced this pull request Oct 27, 2023
* 'main' of https://github.com/elastic/apm-agent-java: (35 commits)
  buildkite: opentelemetry+elastic agent overhead benchmark on a weekly basis (elastic#3371)
  ci(action): remove unrequired action (elastic#3387)
  Bump org.springframework.boot:spring-boot-dependencies from 2.7.16 to 3.1.5 (elastic#3380)
  ci(action): archive benchmarks.jar (elastic#3386)
  remove noise (elastic#3385)
  Process otel benchmark (elastic#3384)
  Update tests for Jedis 5 (elastic#3382)
  added entry to community plugins (elastic#3383)
  added capturing s3 otel attributes from lamba S3Event (elastic#3364)
  Bump version.log4j from 2.12.4 to 2.21.0 (elastic#3366)
  Fix aws sdk instrumentation (elastic#3373)
  action: remove leftover from Jenkins (elastic#3368)
  Bump org.apache.logging.log4j:log4j-bom from 2.20.0 to 2.21.0 (elastic#3367)
  Bump io.micrometer:micrometer-core from 1.11.4 to 1.11.5 (elastic#3360)
  Add guard against invalid end timestamps (elastic#3363)
  Added otel to dependabot config, upgraded dependencies (elastic#3359)
  Bump version.byte-buddy from 1.14.8 to 1.14.9 (elastic#3361)
  Fix off-by-one error in tests which effectively disabled recycling validation (elastic#3357)
  Fix multiple spans being created for HTTPUrlConnection HEAD requests (elastic#3353)
  Bump org.ow2.asm:asm-tree from 9.5 to 9.6 (elastic#3349)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community ready-to-merge triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[META 790] Add Bucket and Object Key to Lambda transactions that are triggered by S3
3 participants