Adding filters should not force initialization of Agent. #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead if the agent is not yet setup we simply buffer the filters until the agent gets constructed.
This allows you to add filters before initializing the static agent.
This manifested itself in the hosted service integrations (.NET Core) where the agent get's constructed slightly delayed.
And calling
```
Agent.AddFilter((ISpan span) =>
{
return span;
});
```
Would win the race for `Agent.Instance` over the ASP.NET core integrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead if the agent is not yet setup we simply buffer the filters until the agent gets constructed.
This allows you to add filters before initializing the static agent.
This manifested itself in the hosted service integrations (.NET Core) where the agent get's constructed slightly delayed.
And calling
Would win the race for
Agent.Instanceover the ASP.NET core integrations.