Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch share to hash #736

Merged
merged 1 commit into from
Feb 9, 2024
Merged

switch share to hash #736

merged 1 commit into from
Feb 9, 2024

Conversation

elalish
Copy link
Owner

@elalish elalish commented Feb 9, 2024

Fixes our URL limit on sharable links by switching to hash: #733 (comment)

@elalish elalish self-assigned this Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79f735c) 91.67% compared to head (f16e675) 91.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #736   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files          37       37           
  Lines        4722     4722           
=======================================
  Hits         4329     4329           
  Misses        393      393           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elalish elalish merged commit 994956d into master Feb 9, 2024
18 checks passed
@elalish elalish deleted the gzipShare branch February 9, 2024 01:19
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant