Merge pull request #76 from ekristen/fix-config-nil-pointer

fix(config): check if filters is nil before resolving deprecations

pkg/config/config.go

@@ -236,6 +236,11 @@ func (c *Config) Filters(accountID string) (filter.Filters, error) {
 // new resource type.
 func (c *Config) ResolveDeprecations() error {
 	for _, a := range c.Accounts {
+		// Note: if there are no filters defined, then there's no substitution to perform.
+		if a.Filters == nil {
+			return nil
+		}
+
 		for resourceType, resources := range a.Filters {
 			replacement, ok := c.Deprecations[resourceType]
 			if !ok {

pkg/config/config_test.go

@@ -160,6 +160,20 @@ func TestResourceTypeDeprecations(t *testing.T) {
 	assert.NoError(t, err)
 }
 
+func TestResourceTypeDeprecationsNoFilters(t *testing.T) {
+	opts := Options{
+		Path:                  "testdata/deprecated-resources-no-filters.yaml",
+		Deprecations:          map[string]string{"IamRole": "IAMRole"},
+		NoResolveDeprecations: true,
+	}
+	c, err := New(opts)
+	assert.NoError(t, err)
+	assert.NotNil(t, c)
+
+	err = c.ResolveDeprecations()
+	assert.NoError(t, err)
+}
+
 func TestResourceTypeDeprecationsError(t *testing.T) {
 	logrus.AddHook(&TestGlobalHook{
 		t: t,

pkg/config/testdata/deprecated-resources-no-filters.yaml

@@ -0,0 +1,25 @@
+---
+regions:
+  - us-east-1
+
+blocklist:
+  - 1234567890
+
+resource-types:
+  includes:
+    - IAMRole
+
+accounts:
+  555133742:
+    presets:
+      - "terraform"
+    resource-types:
+      includes:
+        - S3Bucket
+
+presets:
+  terraform:
+    filters:
+      S3Bucket:
+        - type: glob
+          value: "my-statebucket-*"