Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTORING]: deleting repeated code for VitalityTable and creating VitalityTitle #80

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

OlgaYasn
Copy link
Collaborator

@OlgaYasn OlgaYasn commented Jan 7, 2025

Pull Request Template

✨ Title

  • [REFACTORING]: deleting repeated code for VitalityTable and creating VitalityTitle

πŸ“„ Description

Managed to drop the duplication rate from 12.37% to 12,04%

βœ… Checklist

  • I have read and followed the Contribution Guide.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings or errors.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

πŸ”— Contextual Links (optional)

Add any relevant links to tracking tickets, previous discussions, or other resources.

πŸ“Έ Visuals (optional)

Capture d’écran 2025-01-07 Γ  15 15 24 Capture d’écran 2025-01-07 aΜ€ 15 13 58

πŸ” Reviewers

Please assign at least one reviewer for this PR. The PR cannot be merged until it is approved by the reviewer(s).

@OlgaYasn OlgaYasn added the WIP Work in progress label Jan 7, 2025
@OlgaYasn OlgaYasn force-pushed the refactor/ISSUE-58/code-duplication branch from 97f791c to 1471f31 Compare January 7, 2025 14:23
@OlgaYasn OlgaYasn self-assigned this Jan 7, 2025
@OlgaYasn OlgaYasn changed the title Refactor/issue 58/code duplication [REFACTORING]: deleting repeated code for VitalityTable and creating VitalityTitle Jan 7, 2025
@OlgaYasn OlgaYasn linked an issue Jan 7, 2025 that may be closed by this pull request
2 tasks

}

const RenderVitalityTable: React.FC<RenderVitalityTableProps> = ({ dataSource, columnKeys, columnOptions }) => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventually change name : VitalityTable and VitalityTable becomes VitalityBaseTable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUDIT]: static code analysis (remove duplications & circular dependencies)
1 participant