This repository has been archived by the owner on May 27, 2024. It is now read-only.
Add pararhyme #10
Open
Add pararhyme #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all the logic to separate functions, so new types of rhymes can easily be added.
Words that does pararhyme are now also considered to rhyme. A pararhyme is two words of equal lenght where all consonants match.
| if not (len(word1) == len(word2)): | ||
| return False | ||
|
|
||
| for letter1, letter2 in zip(word1, word2): |
There was a problem hiding this comment.
all(letter1 == letter2 or is_vowel(letter1, letter2) for letter1, letter2 in zip(word1,word2))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4
This PR adds pararhyme to rhymes that are considered.