handle string arg to alterPaymentType in case of aggregation #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adixon -not sure how this commit is conflicted? It's certainly not cos of other merges since the patch you wrote since this extension is gliding into obselescence |
|
I am also confused about the conflict, but leave such issues to wiser minds. This PR is really just a placeholder, I have no idea if it's the right answer. It seems like it's trying to solve one version of a more widespread issue, i.e. aggregation and how that mangles the alter arguments into these comma-delimited strings. But none of us really want to think about the old reports code any more .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #546