Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new approach for benchmarking execute scripts #191

Merged
merged 1 commit into from
May 23, 2024
Merged

feat: new approach for benchmarking execute scripts #191

merged 1 commit into from
May 23, 2024

Conversation

neutrinoks
Copy link
Contributor

@neutrinoks neutrinoks commented May 23, 2024 •
edited
Loading

  • introduce a new approach for benchmarking extrinsic call execute
  • add new bash scripts to generate Move scripts with constant gas costs easily
  • adapt build procedure for Move project asset gas-costs
  • update Substrate weights for pallet-move after running the modified benchmark

@neutrinoks neutrinoks requested a review from Rqnsom May 23, 2024 09:53
@neutrinoks neutrinoks self-assigned this May 23, 2024
@neutrinoks neutrinoks force-pushed the feat/benchmarking-with-cheap-scripts branch from 45fc6f1 to b83374d Compare May 23, 2024 09:56
Rqnsom
Rqnsom reviewed May 23, 2024
View reviewed changes
pallet/src/weights.rs Outdated Show resolved Hide resolved
@neutrinoks neutrinoks force-pushed the feat/benchmarking-with-cheap-scripts branch from b83374d to eed4acd Compare May 23, 2024 10:17
Rqnsom
Rqnsom previously approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool script!
LGTM 🚀

@neutrinoks neutrinoks force-pushed the feat/benchmarking-with-cheap-scripts branch from eed4acd to d808b47 Compare May 23, 2024 10:28
@neutrinoks neutrinoks merged commit ac61010 into main May 23, 2024
1 check passed
@neutrinoks neutrinoks deleted the feat/benchmarking-with-cheap-scripts branch May 23, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rqnsom Rqnsom Rqnsom approved these changes

Assignees

@neutrinoks neutrinoks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoks @Rqnsom