refactor: optimise solo signer in regards to multisig functionality #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Rqnsom
commented
Mar 26, 2024
Rqnsom
commented
- Optimization included.
- Included new tests.
- Fixed one tiny bug that allowed users to fill out the multisig storage when the wrong user tried to sign the single signer script.
neutrinoks
reviewed
Mar 26, 2024
Rqnsom
force-pushed
the
m3/refactor/solo-signers
branch
from
3c94415 to
a0668c4
Compare
- Optimization included. - Block calculation updated. (for cleaning up the multisig storage) - Included new tests. - Updated existing tests with additional checks. - Fixed one tiny bug that allowed users to fill out the multisig storage when the wrong user tried to sign the single signer script.
Rqnsom
force-pushed
the
m3/refactor/solo-signers
branch
from
a0668c4 to
fb7fdf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.