Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement currency locking and extend testing #158

Conversation

neutrinoks
Copy link
Contributor

@neutrinoks neutrinoks commented Mar 7, 2024

  • implemented currency locking in case of multi-signer execution requests
  • extended existing unit tests for checking this implementation
  • added a new unit test about checking the cheque limit in case of multi-signer requests
  • fixed the GitHub CI action because otherwise, the checks wouldn't have been triggered in this PR

@neutrinoks neutrinoks requested a review from Rqnsom March 7, 2024 17:34
@neutrinoks neutrinoks self-assigned this Mar 7, 2024
@neutrinoks neutrinoks force-pushed the feat/multi-signer-currency-lock-and-tests branch 2 times, most recently from 3ae859c to cafa764 Compare March 8, 2024 08:48
@neutrinoks neutrinoks force-pushed the feat/multi-signer-currency-lock-and-tests branch from cafa764 to 8682a08 Compare March 8, 2024 09:00
Rqnsom
Rqnsom previously approved these changes Mar 8, 2024
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pallet/src/tests/signer.rs Outdated Show resolved Hide resolved
pallet/src/tests/signer.rs Outdated Show resolved Hide resolved
pallet/src/tests/signer.rs Outdated Show resolved Hide resolved
pallet/src/tests/signer.rs Outdated Show resolved Hide resolved
pallet/src/tests/signer.rs Outdated Show resolved Hide resolved
pallet/src/tests/signer.rs Outdated Show resolved Hide resolved
pallet/src/tests/signer.rs Show resolved Hide resolved
pallet/src/tests/signer.rs Outdated Show resolved Hide resolved
pallet/src/lib.rs Show resolved Hide resolved
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@neutrinoks neutrinoks merged commit f3c2522 into feat/main-milestone-three Mar 8, 2024
1 check passed
@neutrinoks neutrinoks deleted the feat/multi-signer-currency-lock-and-tests branch March 8, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants