Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow suite runners read testrun objects #41

Conversation

andmat900
Copy link
Contributor

Applicable Issues

Description of the Change

This change adds a role with a rolebinding to allow suite runners read testrun custom objects. This is needed to avoid passing TERCC to suite runners via environment variable. The variables have a size limit and larger TERCCs cannot fit into it.

Alternate Designs

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Andrei Matveyeu, [email protected]

@andmat900 andmat900 requested a review from a team as a code owner November 13, 2024 12:15
@andmat900 andmat900 requested review from t-persson and fredjn and removed request for a team November 13, 2024 12:15
@t-persson
Copy link
Collaborator

This is not the correct place to add this. The suite starter does not create TestRun resources and the controller cluster does not use these YAML files.

The role, service account and rolebinding should be deployed in the ClusterController: https://github.com/eiffel-community/etos/blob/main/internal/etos/etos.go or https://github.com/eiffel-community/etos/pull/291/files#diff-c0d129f92fe352ef7ee6d705328944f3cbdedfff18bc96e65e686718b382c8c7R119

@andmat900 andmat900 closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants