Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add terminationGracePeriodSeconds to Job template #32

Merged

Conversation

andmat900
Copy link
Contributor

Applicable Issues

Description of the Change

This change sets an increased graceful termination timeout for a job. The new default value is 300 seconds.

Alternate Designs

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Andrei Matveyeu, [email protected]

@andmat900 andmat900 requested a review from a team as a code owner February 21, 2024 14:14
@andmat900 andmat900 requested review from t-persson and fredjn and removed request for a team February 21, 2024 14:14
@andmat900 andmat900 force-pushed the 20240221_termination_period branch 2 times, most recently from 611eeac to 43736c1 Compare February 23, 2024 08:43
Copy link
Collaborator

@t-persson t-persson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you write solves: eiffel-community/etos#209 or fixes: eiffel-community/etos#209 in the applicable issues field, the issue will be automatically closed when you merge this PR

@andmat900 andmat900 force-pushed the 20240221_termination_period branch 3 times, most recently from 1c8cfce to 3bd19d4 Compare February 28, 2024 14:19
@andmat900 andmat900 force-pushed the 20240221_termination_period branch from 3bd19d4 to d3865ad Compare February 28, 2024 14:23
@t-persson t-persson merged commit 2cd118f into eiffel-community:main Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants