Skip to content

Commit

Permalink
Fixes after rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
t-persson committed Nov 27, 2024
1 parent 9e806d4 commit 7a27c7e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion internal/config/base.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func (c *baseCfg) ServicePort() string {
}

// StripPrefix returns the prefix to strip. Empty string if no prefix.
func (c *cfg) StripPrefix() string {
func (c *baseCfg) StripPrefix() string {
return c.stripPrefix
}

Expand Down
7 changes: 0 additions & 7 deletions internal/config/executionspace.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (

type ExecutionSpaceConfig interface {
Config
StripPrefix() string
Hostname() string
Timeout() time.Duration
ExecutionSpaceWaitTimeout() time.Duration
Expand Down Expand Up @@ -60,7 +59,6 @@ func NewExecutionSpaceConfig() ExecutionSpaceConfig {
logrus.Panic(err)
}

flag.StringVar(&conf.stripPrefix, "stripprefix", EnvOrDefault("STRIP_PREFIX", ""), "Strip prefix")
flag.StringVar(&conf.hostname, "hostname", EnvOrDefault("PROVIDER_HOSTNAME", "http://localhost"), "Host to supply to ESR for starting executors")
flag.DurationVar(&conf.timeout, "timeout", defaultTimeout, "Maximum timeout for requests to Execution space provider Service.")
flag.DurationVar(&conf.executionSpaceWaitTimeout, "executionSpaceWaitTimeout", executionSpaceWaitTimeout, "Timeout duration to wait when trying to checkout execution space(s)")
Expand All @@ -74,11 +72,6 @@ func NewExecutionSpaceConfig() ExecutionSpaceConfig {
return &conf
}

// StripPrefix returns a prefix that is supposed to be stripped from URL.
func (c *executionSpaceCfg) StripPrefix() string {
return c.stripPrefix
}

// Hostname returns the hostname to use for executors.
func (c *executionSpaceCfg) Hostname() string {
return c.hostname
Expand Down

0 comments on commit 7a27c7e

Please sign in to comment.