Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Add example of working with Git submodules #404

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Fredrik10a
Copy link

@Fredrik10a Fredrik10a commented Nov 5, 2024

Applicable Issues

Task from the October 2024 community meeting to capture the discussion on how a submodule setup could look like.

Description of the Change

Added a page describing how to model submodules using Eiffel events.

Alternate Designs

Not Applicable

Possible Drawbacks

Nothing that I can think of

@Fredrik10a Fredrik10a requested a review from a team as a code owner November 5, 2024 14:58
Copy link
Member

@m-linner-ericsson m-linner-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution and glad to have you onboard!

Could I ask you fill in the PR template with some text and put your signature in the form of name and email? You don't need to be very lengthy but some explanation on what the update was. I would probably have added the following:

### Applicable Issues
Task from the [October 2024 community meeting](https://hackmd.io/e5x-6vRGSnio02m8snhn0A) to capture the discussion on how a submodule setup could look like.

### Description of the Change
Added a page describing how to model submodules using Eiffel events.


### Alternate Designs
Not Applicable

### Possible Drawbacks
Nothing  that I can think of

It could be that you only wanted to create a draft PR https://github.blog/news-insights/product-news/introducing-draft-pull-requests/ . In that case we don't require you to fill in the PR template just to get the discussion started.

If you got any question please don't hesitate to ask or reach out to me. No question is too stupid.

usage-examples/submodules-eiffel.md Outdated Show resolved Hide resolved

![alt text](./submodules-eiffel.png)

Depending on the solution setup, a Service can be created to listen for SCCs (Source Change Created) that carry a specific identification tag/id for the Parent repository. Upon detecting such an SCC, the Service uses the SourceChange API to read the SHA IDs of contained submodules. It then fetches the related SCCs based on these IDs. Finally, it generates a CompositionDefined (CD) event and publishes it on the bus.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some problems following how this could look like. Could you add the link names in the picture?

Copy link
Author

@Fredrik10a Fredrik10a Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Eiffel representation of the root issue below ## Eiffel solution that model the Eiffel solution with Events.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didn't follow there. Could you elaborate?

@Fredrik10a Fredrik10a changed the title Add example of working with Git submodules [DRAFT] Add example of working with Git submodules Nov 7, 2024
@m-linner-ericsson m-linner-ericsson requested a review from a team December 4, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants