Implemented code changes to add the default domainId value, #139
Conversation
if its not provided by user
sudharshan-bandaru
requested review from
SantoshNC68,
Surya-Kolli and
raja-maragani
Fixed the comments |
There was a problem hiding this comment.
Why is this change being made (the linked issue gives no justification)? For sites not using multiple domains, why force events to include a domain id? For sites that do use multiple domains, what's the use of a generic and rather useless "domainID" string? If you really want a domain id, why not mandate it (i.e. reject submissions without a domain id)?
| "version": "4.0.0", | ||
| "tags": ["product_development","product_feature1"], | ||
| "source": { | ||
| "domainId": "", |
There was a problem hiding this comment.
This event has an empty domain id yet the filename suggests that the domain id is missing. The way I read setDomainId() it won't touch the domain id if the key is missing altogether, it'll only set it if the string is empty. Is that really what's intended?
if its not provided by user
Applicable Issues
REMReM-semantics doesn't add the default domain id if not provided by the user.
For more details#138
Description of the Change
Implemented code changes to add the default domainId value, if its not provided by user.
Alternate Designs
Benefits
Even in the case of User is not provided the domainId REMReM-semantics will add the default domainId
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Sudharshan Bandaru [email protected]