Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for REMReM publish in Opensource. #185

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Documentation for REMReM publish in Opensource. #185

merged 1 commit into from
Jan 14, 2020

Conversation

iamrishavkumar
Copy link
Contributor

Applicable Issues

#168

Description of the Change

Alternate Designs

Benefits

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by:

wiki/markdown/index.md Outdated Show resolved Hide resolved
wiki/markdown/usage.md Outdated Show resolved Hide resolved
wiki/markdown/cliUsage.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@magnusbaeck magnusbaeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR is just for moving the existing contents from gh-pages to markdown without making any actual changes I guess my suggestions for general improvements are out of place.


* JDK 8
* Tomcat 8
* RabbitMQ Server 3.6.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.6.x or later, right? And perhaps that qualifier applies to the JDK and Tomcat too?

Comment on lines 144 to 175
<table>
<tbody>
<tr>
<th style="text-align: left;">Exit code</th>
<th style="text-align: left;">Description</th>
</tr>
<tr>
<td>1</td>
<td>User will get this exit code in case of some error that is not described below</td>
</tr>
<tr>
<td>2</td>
<td>Some CLI options are missed</td>
</tr>
<tr>
<td>3</td>
<td>Passed message protocol or message bus configuration are not correct</td>
</tr>
<tr>
<td>4</td>
<td>Passed file path is wrong. File is not found</td>
</tr>
<tr>
<td>5</td>
<td>Unable to read content from passed file path</td>
</tr>
<tr>
<td>6</td>
<td>Unable to read passed JSON string from command line</td>
</tr>
</tbody>
</table>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason not to use Markdown table markup? It's easier on the eyes if reading the raw .md file and arguably less tedious to maintain.


If you are using linux machine, please follow the below steps

Add the file *application.properties* to *%CATALINA_HOME%\conf*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${CATALINA_HOME}/conf or $CATALINA_HOME/conf, not %CATALINA_HOME%\conf.

Comment on lines 136 to 143
<protocol>.rabbitmq.host: <host name, eg: localhost>
<protocol>.rabbitmq.port: <port, eg: 5672>
<protocol>.rabbitmq.username: <username, default for RabbitMQ Server: guest>
<protocol>.rabbitmq.password: <password, default for RabbitMQ Server: guest>
<protocol>.rabbitmq.tls: <tls version, is optional>
<protocol>.rabbitmq.exchangeName: <exchange name, exchange should be already created on RabbitMQ Server>
<protocol>.rabbitmq.createExchangeIfNotExisting: <create Exchange if not present on RabbitMQ Server>
<protocol>.rabbitmq.domainId: <domain id, any string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall exactly how these properties relate to the configurations specified in the rabbitmq.instance.jsonlist property, but unless the latter is set none of the properties above matter. Please see #176 for a description of how confusing all of this is. As I write in that issue I think the configuration interface should be overhauled completely, but the least we can do is document the current interface.

README.md Outdated Show resolved Hide resolved
wiki/markdown/cliUsage.md Outdated Show resolved Hide resolved
wiki/markdown/serviceUsage.md Outdated Show resolved Hide resolved
wiki/markdown/serviceUsage.md Outdated Show resolved Hide resolved
Copy link
Member

@e-pettersson-ericsson e-pettersson-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 😄

@@ -0,0 +1,156 @@
# REMReM Publish CLI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this file to /usage/cli.md

@@ -0,0 +1,360 @@
# REMReM Publish Service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this file to /usage/service.md

@@ -0,0 +1,156 @@
# REMReM Publish CLI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wiki/markdown/usage/cli.md

@@ -0,0 +1,360 @@
# REMReM Publish Service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wiki/markdown/usage/service.md

@Umadevi-Kapu Umadevi-Kapu merged commit 4348c14 into eiffel-community:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants