Remove Vici from Easy2Use bundles #89
Conversation
|
The self-hosted runner was not working properly for some reason. The CI pipeline, however, has passed in the dev branch. I will try to retrigger the pipeline another time. |
| @@ -70,7 +70,7 @@ jobs: | |||
| bash remrem_publish_event.bash -d $DOMAIN -n $NAMESPACE | |||
|
|
|||
| : # Wait for a while until the processing of the events | |||
| echo "Waiting..." && sleep 60 | |||
| echo "Waiting..." && sleep 90 | |||
There was a problem hiding this comment.
Do we have any to check this instead of doing a sleep?
There was a problem hiding this comment.
Actually, we give some time to the Eiffel events process and the Jenkins jobs to be executed. A minute is not enough always, so I increased it to 1.5 min.
There was a problem hiding this comment.
I don't question that we have to wait I was wondering if we could poll the Jenkins jobs or something that knows when the task is ready instead of just doing a sleep and hope that it will finish in time.
There was a problem hiding this comment.
We check if the Jenkins jobs are done in the next pipeline step "Ensure that Jenkins jobs executed successfully".
Applicable Issues
#87
Description of the Change
Remove Vici service from the bundles.
Alternate Designs
N/A
Possible Drawbacks
Eiffel will not support any visualization service. However, Vici was a "broken" service.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Panagiotis Efstratiou