Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRC: avoid hardcoding number of glued bars #824

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 15, 2025

Briefly, what does this PR introduce?

This should not change the baseline geometry, but this allows to play with alternative values of the DIRCBar_count_z constant, which is set to 4 by default.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@github-actions github-actions bot added topic: barrel Mid-rapidity detectors topic: PID Particle identification labels Jan 15, 2025
@veprbl veprbl requested review from DraTeots and niwgit January 15, 2025 17:49
@veprbl veprbl requested review from rahmans1 and Chao1009 January 23, 2025 10:56
Copy link
Contributor

@Chao1009 Chao1009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl enabled auto-merge (squash) January 23, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: barrel Mid-rapidity detectors topic: PID Particle identification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants