Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

definitions.xml: ECal -> Ecal, HCal -> Hcal for ID fields #631

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Feb 9, 2024

First step for #557 in which we provide Ecal* and Hcal* names.

Next step would be to use those names in EICrecon.

Final step is to remove the deprecated aliases.

@github-actions github-actions bot added topic: barrel Mid-rapidity detectors topic: forward Positive-rapidity detectors (hadron-going side) topic: backward Negative-rapidity detectors (electron-going side) topic: calorimetry labels Feb 9, 2024
@veprbl veprbl enabled auto-merge February 10, 2024 01:18
compact/definitions.xml Outdated Show resolved Hide resolved
@veprbl veprbl added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit c37c373 Feb 12, 2024
89 checks passed
@veprbl veprbl deleted the pr/use_Ecal_Hcal_for_IDs branch February 12, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: backward Negative-rapidity detectors (electron-going side) topic: barrel Mid-rapidity detectors topic: calorimetry topic: forward Positive-rapidity detectors (hadron-going side)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants