-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hpc rework #289
Merged
Merged
Hpc rework #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lurm script, and reworked S3 reading on slurm with xrootd
…nEvents.Now calculates the Q2weights which are manually inserted into the split config files. Also handled XsTotal, WeightTrackTotal, and TotalEvents in the merge.
…, all in parallel
…gns and append the nevents to a cached database for each file
… comments) is fixed
Testing it on ifarm now, but it might be nice to have an option similar to the energy settings to select only whatever Q2 ranges you're interested in (not sure if this would make the Q2 weighting a pain though) |
7 tasks
Tested this again while being better at reading all your comments in the readme, and it seems like your default memory request should be okay up to 3 files per job. |
cpecar
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Parallel computing capabilities with JLab's ifarm computing. Allows for multiple root files to be analyzed per job while maintaining proper Q2weighting across entire pipeline.
New script titled
hpc/run-local-slurm-pipeline.rb
creates the full pipeline that is run with a 'single button press'. After running the script, it will generate a new "run" script inhpc/project_scripts
that will do the following for each campaign and beam energy..config
file for the chosen campaign, detector configuration, and beam energy.config
file into multiple batches, with a number ofROOT
files per batch specified by the userQ2
range studied, either by reading the TTrees directly or calling their values from csvs inhpc/nevents_database
. New files have their number of events automatically added to the database for faster access in the future.Q2weights
for each range and insert them into the batched.config
files.config
file on the analysis macro specified by the userWhat kind of change does this PR introduce?
ifarm
Slurm #236)Q2weight
issue wherebeamCrossing!=0
changes the trueQ2 of the event, causing us to assign itsQ2weight
to the wrong value.Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?
Yes. See
Q2weight
issue above.