New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: make `AnalysisEpic` compatible with production 22.11.2 #208

Merged

c-dilks merged 35 commits into main from temp.epic.ana

Dec 15, 2022

Contributor

Gregtom3 commented Nov 28, 2022

Reverting back to the original MC<-->Reco particle matching algorithm for the Epic detector sims until the podio framework is fixed.

c-dilks and others added 9 commits

November 9, 2022 14:38


          test: AnalysisEpic on 22.10.0 single particle simulations

6fe6051


          feat: initial AnalysisEpic support for campaign 22.11+

57c5724


          modified: tutorial/analysis_epic.C

4157ee7


          introduce caching of PDG values, in preparation for PID smearing

cf7adbc


          Integrated a Reco<-->MC matching algorithm to the Epic analysis. Temp…

699759d

…orary until the campaign fixes podio issues


          Merge remote-tracking branch 'origin/main' into temp.epic.ana

bbe9975


          fix: weight -> weightTrack

37b5feb


          Prototyping

c450ac4


          Working particle matching with ParticleTree

427760a

c-dilks marked this pull request as draft

November 28, 2022 18:33

Gregtom3 and others added 7 commits

November 28, 2022 16:11


          Edit

e1efecb


          ParticleTree anaylsis script

3fcceec


          ci: add AnalysisEpic comparison plots

6b9f6a2


          modified: .github/workflows/ci.yml

1db144c


          ci: add AnalysisEpic comparison plots

c9e1a45


          Merge remote-tracking branch 'origin/main' into temp.epic.ana

630ec07


          add copyright notices

721ccb1

c-dilks changed the title ~~Temp.epic.ana~~ refactor: revert to TTreeReader in AnalysisEpic

c-dilks added the fullsim label

c-dilks marked this pull request as ready for review

November 30, 2022 05:06

c-dilks added 2 commits

November 30, 2022 00:35


          remove all podio dependence from AnalysisEpic

c463d8a


          new file DataModel.h to hold common Particles class; add particle m…

f4150a7

…asses to `CommonConstants.h`

c-dilks linked an issue

that may be closed by this pull request

AnalysisAthena::Particles and AnalysisEcce::ParticlesEE are the same; merge them #216

Closed

3 tasks


          minor changes

000c451

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Outdated Show resolved Hide resolved

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Show resolved Hide resolved

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Outdated Show resolved Hide resolved

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Outdated Show resolved Hide resolved

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Outdated Show resolved Hide resolved

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Outdated Show resolved Hide resolved

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Outdated Show resolved Hide resolved

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Outdated Show resolved Hide resolved

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Show resolved Hide resolved

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Outdated Show resolved Hide resolved

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Outdated Show resolved Hide resolved

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Show resolved Hide resolved

c-dilks reviewed

View reviewed changes

src/AnalysisEpic.cxx Outdated Show resolved Hide resolved

c-dilks changed the title ~~refactor: revert to TTreeReader in AnalysisEpic~~ feat!: make AnalysisEpic compatible with production 22.11.2

c-dilks mentioned this pull request

Duplicated code in Analysis-derived classes should be moved to base class Analysis #217

Open

Gregtom3 and others added 11 commits

December 5, 2022 13:02


          Refactoring track variables to recpart

ed30783


          Mass calculation typo

ee675bf


          Incrementor

d7cf364


          index mc bound change

85d8470


          ParticleTree removed from nested loop and placed in separate loop ove…

b2e90fd

…r all reconstructed particles


          ParticleTree tweaks, remove weights

3fc21c5


          Postprocess notebook rerun with recent commit changes

56cb967


          update documentation and tutorial

3572a81


          fix: unused class rule warning

55ac090


          ci: increase stats for AnalysisEpic

bc4fab7


          Added pythia 6 cross sections for epic simulations with and without r…

18f62dc

…adiative corrections to the cross section table

c-dilks linked an issue

that may be closed by this pull request

Cross sections for the EPIC Pythia6 files #211

Closed

2 tasks

c-dilks added 5 commits

December 7, 2022 12:43


          move EPIC cross sections to the top of xsec.dat

e722c02


          update comments to clarify HEPMC file paths

05adfbf


          fix: disable unused Particles::charge in AnalysisEpic

2b152fd


          doc: clarify comment

92e75be


          deleted: tutorial/s3files.*.config

f7ca1f6

c-dilks approved these changes

View reviewed changes

c-dilks merged commit 38a86b3 into main

c-dilks deleted the temp.epic.ana branch

December 15, 2022 17:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels