Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EventHeader check to be non fatal #1698

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

simonge
Copy link
Contributor

@simonge simonge commented Jan 8, 2025

Briefly, what does this PR introduce?

Allows running of EICrecon on files without an EventHeader collection. Files with a single/small subset of output collections can have analysis continued without needing to manually persist EventHeader.

A warning has been added.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@simonge simonge linked an issue Jan 8, 2025 that may be closed by this pull request
@veprbl veprbl requested review from a team and veprbl and removed request for a team January 9, 2025 00:09
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably okay for now, but only because we don't rely on those numbers. Once conditions DBs are implemented, this will have to be provided somehow.

@simonge simonge added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 8fa634b Jan 9, 2025
86 checks passed
@simonge simonge deleted the 1696-make-eventheader-collection-non-essential branch January 9, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make EventHeader collection non-essential
2 participants