run clang-format in CI #1692
run clang-format in CI #1692
Conversation
github-actions
bot
added
topic: infrastructure
topic: documentation
veprbl
force-pushed
the
pr/clang-format-ci
branch
from
ff278ba to
a84a2c9
Compare
veprbl
force-pushed
the
pr/clang-format-ci
branch
from
2d55bbd to
bc11374
Compare
for more information, see https://pre-commit.ci
Capybara summary for PR 1692
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| //------------------------------------------- | ||
| // FinishWithGlobalRootLock | ||
| //------------------------------------------- | ||
| void TofEfficiency_processor::FinishWithGlobalRootLock() { | ||
|
|
||
| // Do any final calculations here. | ||
|
|
||
| // Do any final calculations here. | ||
| } | ||
|
|
||
| int TofEfficiency_processor::IsTOFHit(float x, float y, float z) { |
There was a problem hiding this comment.
2 adjacent parameters of IsTOFHit of similar type (float) are easily swapped by mistake
| // warning("{} eV is out of QE data range, assuming 0\% efficiency",ev); | ||
| return false; | ||
| } | ||
| bool PhotoMultiplierHitDigi::qe_pass(double ev, double rand) const { |
There was a problem hiding this comment.
2 adjacent parameters of qe_pass of similar type (double) are easily swapped by mistake
| part.addToClusters(*cluster); | ||
| return part; | ||
| edm4eic::MutableReconstructedParticle | ||
| MatchClusters::reconstruct_neutral(const edm4eic::Cluster* cluster, const double mass, |
There was a problem hiding this comment.
2 adjacent parameters of reconstruct_neutral of convertible types are easily swapped by mistake
| (float)vtx.position().z(), | ||
| (float)vtx.time(), | ||
| }); // vtxposition | ||
| eicvertex.setPositionError(cov); // covariance | ||
|
|
||
| for (const auto& t : vtx.tracks()) { | ||
| #if Acts_VERSION_MAJOR >= 33 | ||
| const auto& par = finderCfg.extractParameters(t.originalParams); |
There was a problem hiding this comment.
finderCfg used after it was moved
| if (traj->hasTrackParameters(trackTip)) { | ||
| const auto& boundParam = traj->trackParameters(trackTip); | ||
| const auto& parameter = boundParam.parameters(); | ||
| const auto& covariance = *boundParam.covariance(); |
There was a problem hiding this comment.
unchecked access to optional value
| m_log->trace(" propagation result is OK"); | ||
|
|
||
| // Pulling results to convenient variables | ||
| auto trackStateParams = *((*result).endParameters); |
There was a problem hiding this comment.
unchecked access to optional value
| // Pulling results to convenient variables | ||
| auto trackStateParams = *((*result).endParameters); | ||
| const auto& parameter = trackStateParams.parameters(); | ||
| const auto& covariance = *trackStateParams.covariance(); |
There was a problem hiding this comment.
unchecked access to optional value
Briefly, what does this PR introduce?
This is like eic/epic#705
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Yes, current PR's will have to be rebased, however there is a procedure to do edits fully automated.
Does this PR change default behavior?
No