Allow xrootd files as inputs to eicrecon

[simonge]

Briefly, what does this PR introduce?

Currently eicrecon has two checks for files existing, neither of which allow the file to be on a remote xrootd server. This PR adapts JEventSourcePODIO.cc so that the first check allows for remote files and (currently) removes the second check.

What kind of change does this PR introduce?

• Bug fix (issue #__)
• New feature (issue #__)
• Documentation update
• Other: __

Please check if this PR fulfills the following:

• Tests for the changes have been added
• Documentation has been added / updated
• Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

tbd

Does this PR change default behavior?

Allows remote files to be passed directly to eicrecon

[simonge]

Questions:
Is there a situation in which both checks are required?
Can Open() just do the second check with CheckOpenable()?

[github-actions]

Capybara summary for PR 1690

• rec_dis_10x100_minQ2=0_craterlake
• rec_dis_10x100_minQ2=1000_craterlake_tracking_only
• rec_dis_18x275_minQ2=0_craterlake_18x275
• rec_dis_18x275_minQ2=1000_craterlake_18x275
• rec_dis_5x41_minQ2=0_craterlake_5x41
• rec_e_1GeV_20GeV_craterlake
• rec_pi_1GeV_20GeV_craterlake
  ^{_{Last updated 2024-12-20T03:09-05:00 2091fb0}}

[veprbl]

After testing this on my side, I think, I understand this better now. The check being removed is seemingly impossible to even trigger as TFile's exception in CheckOpenable happen before it and are not being caught. Thus this change does not modify the current behaviour and does provide promised functionality (streaming from XRootD).

[veprbl]

LGTM

[simonge]

Should a test be added for this or is the Jlab XRootD server and file locations potentially too volatile to want to rely on?

[veprbl]

You are welcome to add a test. I don't think full simulations are published anymore. There will be some old ones, and reconstruction can be restricted to few detectors that don't rely on [a consistent] geometry being used.