Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: static_cast<float>(sqrt(...)) to avoid c++-narrowing warning/error #1675

Merged
merged 2 commits into from
Nov 20, 2024
Merged

fix: static_cast<float>(sqrt(...)) to avoid c++-narrowing warning/error #1675

merged 2 commits into from
Nov 20, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR should fix the eicrecon build error in https://eicweb.phy.anl.gov/containers/eic_container/-/jobs/4175065/raw (root-6.32.06 upgrade).

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@github-actions github-actions bot added the topic: tracking Relates to tracking reconstruction label Nov 19, 2024
@wdconinc
Copy link
Contributor Author

Not sure why this became an issue with the ROOT upgrade.

@github-actions GitHub Actions
Copy link

Capybara summary for PR 1675

@veprbl veprbl added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit b989c1a Nov 20, 2024
84 of 86 checks passed
@veprbl veprbl deleted the wdconinc-patch-3 branch November 20, 2024 19:23
@wdconinc wdconinc mentioned this pull request Nov 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 1, 2024
@wdconinc
fix: static_cast<float>(sqrt(...)) to avoid c++-narrowing warning/err…
3a507b8 
…or (again) (#1682)

### Briefly, what does this PR introduce?
#1675 again see there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
topic: tracking Relates to tracking reconstruction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wdconinc @veprbl