Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IterativeVertexFinder Acts v33 compatibility #1610

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Sep 7, 2024

Briefly, what does this PR introduce?

This PR fixes the IterativeVertexFinder when compiling for Acts v33. See e.g. https://github.com/acts-project/acts/blob/26b059f3af094df85f5826f4bde95b793f0106d0/Core/src/Vertexing/IterativeVertexFinder.cpp#L468.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@github-actions github-actions bot added the topic: tracking Relates to tracking reconstruction label Sep 7, 2024
@wdconinc wdconinc requested a review from veprbl September 7, 2024 15:19
Copy link

sonarqubecloud bot commented Sep 7, 2024

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@wdconinc wdconinc added this pull request to the merge queue Sep 7, 2024
Merged via the queue into main with commit 17b2aeb Sep 7, 2024
84 of 87 checks passed
@wdconinc wdconinc deleted the iterative-vertex-finder-acts-33 branch September 7, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants