Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in IterativeVertexFinder #1574

Closed
wants to merge 2 commits into from
Closed

Update in IterativeVertexFinder #1574

wants to merge 2 commits into from

Conversation

starsdong
Copy link
Contributor

Briefly, what does this PR introduce?

  • input chosen to use SeededTrajectories
  • added association for ReconstructionParticles to output vertices

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

  • Default input to vertexing changed to CKFSeededActsTrajectories
  • ReconstructedParticle association added to the default output CKFCentralVertices

Xin Dong and others added 2 commits August 16, 2024 14:16
  - input chosen to use SeededTrajectories
  - added association for ReconstructionParticles to output vertices
@github-actions github-actions bot added the topic: tracking Relates to tracking reconstruction label Aug 16, 2024
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@wdconinc
Copy link
Contributor

Please open PRs from branches pushed to the repository itself, not from forks.

@starsdong
Copy link
Contributor Author

Replace with PR #1576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants