Add Track-Based Cluster Merging Algorithm #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Crecon into add-track-cluster-merge-algorithm
Capybara summary for PR 1406
|
for more information, see https://pre-commit.ci
…Crecon into add-track-cluster-merge-algorithm
for more information, see https://pre-commit.ci
…Crecon into add-track-cluster-merge-algorithm
for more information, see https://pre-commit.ci
…Crecon into add-track-cluster-merge-algorithm
for more information, see https://pre-commit.ci
…Crecon into add-track-cluster-merge-algorithm
for more information, see https://pre-commit.ci
ruse-traveler
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ruse-traveler
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ruse-traveler
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Hi all, just wanted to check in on this: do the recent round of commits resolve the open issues? Or is there more to discuss? Thanks! |
|
@ruse-traveler I'd like to spend some more time checking the actual change. Have you done any benchmarking on your end? |
|
Mostly just spot-checks to make sure that it runs and isn't producing stuff that's completely out-to-lunch. I can run some more detailed checks like looking at the E_{clust}/E_{par} in some DIS events. |
7 tasks
veprbl
approved these changes
Sep 17, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR introduces the
TrackClusterMergeSplitteralgorithm, an algorithm for merging and splitting calorimeter clusters based on matched track projections. Inspired by the Particle Flow algorithm from ATLAS.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
Yes. Now "SplitMerge"
edm4eic::Clustercollections and corresponding associations will be created for 6 of the central calorimeters (NHCal,EEEMCal,BHCal,BIC,LFHCal, andFEMC). Track projections will need to be extended to other calorimeters before the algorithm introduced here can be used on them.To-Do
The split-merge parameters for each calorimeter need to be updated from the current dummy values used for testing. In the interest of getting the functionality of this algorithm merged, this could update could be done in a separate PR.