CalorimeterHitDigi: add photon counter based readout #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: calorimetry
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
dismissed
their stale review
No clang-tidy warnings found so I assume my comments were addressed
veprbl
force-pushed
the
pr/photon_digi
branch
2 times, most recently
from
d255212 to
0e70f6f
Compare
Capybara summary for PR 1064Last updated 2024-11-22T02:30-05:00 4fcc822 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
This comes from Athena times where all calorimeters were smeared by 2%. We don't expect this term, we want to have something more motivated like #1064, instead. Submitting separately to confirm the effect.
veprbl
force-pushed
the
pr/photon_digi
branch
from
0e70f6f to
7e769bb
Compare
veprbl
force-pushed
the
pr/photon_digi
branch
from
7e769bb to
7534296
Compare
This implements modes to add additional signal smearing associated with the scintillation process in calorimeters. The SiPM mode allows to study effect of saturation for a given material, light collection efficiency and type of sensor. The part with binomial distribution sampling is a SiPM formalism from Jin Huang's work done for sPhenix: sPHENIX-Collaboration/coresoftware@f746f13
veprbl
force-pushed
the
pr/photon_digi
branch
from
7534296 to
4fcc822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements modes to add additional signal smearing associated with the scintillation process in calorimeters. The SiPM mode allows to study effect of saturation for a given material, light collection efficiency and type of sensor.
The part with binomial distribution sampling is a SiPM formalism from Jin Huang's work done for sPhenix:
sPHENIX-Collaboration/coresoftware@f746f13
Resolves: #696