Skip to content

Commit

Permalink
Update to seed finder distance parameter (#1586)
Browse files Browse the repository at this point in the history
### Briefly, what does this PR introduce?
This updates the parameter which defines the _max distance in r between
middle and top SP in a given seed_. This removes some minor
inefficiencies for |z| > ~50mm at certain eta values, as discussed
[here](https://indico.bnl.gov/event/23932/contributions/93392/attachments/55544/94996/Seed%20finding%20inefficiencies%20for%20%7Cz%7C%20%3E%2050mm.pdf).
Since the beam diamond extends out to 80-100mm, this allows efficient
seed finding over the whole range.

Results for single negative muons generated at with p = [0.5,20]GeV/c
and (vx,vy,vz) = (0,0,50mm)

Before:
<img width="624" alt="picture1"
src="https://github.com/user-attachments/assets/404b9994-47f1-4bf1-8be5-92bb4f5f7879">


After:
<img width="620" alt="picture2"
src="https://github.com/user-attachments/assets/6cd720db-b346-4a29-906d-96525a3b9923">

The results look similar for particles generated at vz = 75mm.

For particles generated at (vx,vy,vz) = (0,0,0), for example, there is
no observed difference in the solved tracks (i.e. tracks after the
ambiguity solver). The number of found seeds and unsolved tracks
increases as expected.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [x] Other: Update to seed finder configuration

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators @Jeet-bhai 

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No

### Does this PR change default behavior?
Yes, small improvement to tracking efficiency

Co-authored-by: ShujieL <[email protected]>
  • Loading branch information
bschmookler and ShujieL authored Aug 22, 2024
1 parent a8c2421 commit 81ff2fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/algorithms/tracking/OrthogonalTrackSeedingConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace eicrecon {
float zMax = 1700. * Acts::UnitConstants::mm; // max z to look for hits to compose seeds
float zMin = -1500. * Acts::UnitConstants::mm; // min z to look for hits to compose seeds
float deltaRMinTopSP = 10. * Acts::UnitConstants::mm; // Min distance in r between middle and top SP in one seed
float deltaRMaxTopSP = 200. * Acts::UnitConstants::mm; // Max distance in r between middle and top SP in one seed
float deltaRMaxTopSP = 450. * Acts::UnitConstants::mm; // Max distance in r between middle and top SP in one seed
float deltaRMinBottomSP = 10. * Acts::UnitConstants::mm; // Min distance in r between middle and bottom SP in one seed
float deltaRMaxBottomSP = 200. * Acts::UnitConstants::mm; // Max distance in r between middle and bottom SP in one seed
float collisionRegionMin = -250 * Acts::UnitConstants::mm; // Min z for primary vertex
Expand Down

0 comments on commit 81ff2fa

Please sign in to comment.