Make reflected binary method transparent #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes reflected binary methods (i.e. `__radd__`) transparent, so that they map directly to the non reflected versions. This differs from the original implementation in #35 (which kept them as separate extensions). That approach had a few flaws: * The `str` representation of binary and non binary operators looked the same, which made them hard to debug. This could have been worked around by non pretty printing the reflective operators (i.e. keeping them as methods instead of operators). * It was hard to define replacements for reflective operators, since they really only were activated on converted/non supported types. This new method is a bit more magic, but should work for any expressions as long as their mathematical operators behave as one would expect for the reversed versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes reflected binary methods (i.e.
__radd__) transparent, so that they map directly to the non reflected versions.This differs from the original implementation in #35 (which kept them as separate extensions).
That approach had a few flaws:
strrepresentation of binary and non binary operators looked the same, which made them hard to debug. This could have been worked around by non pretty printing the reflective operators (i.e. keeping them as methods instead of operators).This new method is a bit more magic, but should work for any expressions as long as their mathematical operators behave as one would expect for the reversed versions.
In this PR the array API notebook can now be run as well!