Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed observer race condition #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stephenth0ma5
Copy link

Background

  • In some edge cases we are observing issues with properly removing the observer because of reliance on superview and isObservingScrollView resulting in observed values getting emitted with no message handler. This ultimately results in a crash.

Changes

  • Instead of relying on superview to remove the observer we can set the observer ourselves when it gets created. This eliminates the need to check if its of type UIScrollView and also eliminates the need for isObservingScrollView since we can use the class-level observer to check if one is set before removing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant