-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support set partitioned property on Chrome >= 114 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cookies Having Independent Partitioned State (CHIPS) https://developers.google.com/privacy-sandbox/3pcd/chips closes #40
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 205 218 +13
Branches 52 57 +5
=========================================
+ Hits 205 218 +13 ☔ View full report in Codecov by Sentry. |
killagu
approved these changes
Dec 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fengmk2
pushed a commit
that referenced
this pull request
Dec 26, 2023
[skip ci] ## [2.8.0](v2.7.1...v2.8.0) (2023-12-26) ### Features * support set partitioned property on Chrome >= 114 ([#42](#42)) ([74325b8](74325b8))
fengmk2
added a commit
to eggjs/egg-session
that referenced
this pull request
Dec 26, 2023
4 tasks
fengmk2
added a commit
to eggjs/egg-session
that referenced
this pull request
Jun 2, 2024
eggjs/egg-cookies#42 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced CI workflow for Node.js projects. - Added GitHub Actions workflow for releasing Node.js applications. - **Documentation** - Updated README: Removed build status, dependencies, and vulnerabilities badges. Improved installation command and added syntax highlighting for code snippets. - **Chores** - Added `package-lock.json` to `.gitignore`. - Updated devDependencies and scripts in `package.json`. - **Tests** - Added new test case for "chips" functionality. - Added new files and configurations for session handling in test fixtures. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookies Having Independent Partitioned State (CHIPS) https://developers.google.com/privacy-sandbox/3pcd/chips
closes #40