Qcom/FdtTargetMmcSdhciLib: Additional FDT parsing #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know pull requests aren't meant to be used this way, but I would like you to test if the changes work on Mi4c too |
M1cha
requested changes
Apr 29, 2018
| //not handled: "cmdq_mem" | ||
| Index++; | ||
| } | ||
|
|
There was a problem hiding this comment.
you have to 0-check sdhc_base and pwrctl_base here
| DEBUG ((DEBUG_INFO, "sdhc_base: %x\n", config.sdhc_base)); | ||
| DEBUG ((DEBUG_INFO, "pwrctl_base: %x\n", config.pwrctl_base)); | ||
|
|
||
| // find interrupt parent | ||
| for (TmpNode = Node; !FdtClient->HasNodeProperty(FdtClient, TmpNode, "interrupt-parent"); Status = FdtClient->GetParentNode(FdtClient, TmpNode, &TmpNode)) { |
There was a problem hiding this comment.
Is that loop needed? I think that linux code only checks the current node and the root node.
Correct me if I'm wrong.
| // get PHandle to interrupt-parent | ||
| Status = FdtClient->GetNodeProperty(FdtClient, TmpNode, "interrupt-parent", (CONST VOID **)&FdtU32, &PropertySize); | ||
| if (EFI_ERROR(Status) || PropertySize != sizeof(*FdtU32)) { | ||
| DEBUG((DEBUG_INFO, "FDT read error: \"interrupt-parent\"\n")); |
| } | ||
| // not handled: hc_irq, status_irq | ||
| Index++; | ||
| } | ||
|
|
There was a problem hiding this comment.
you have to 0-check pwr_irq here.
feherneoh
force-pushed
the
pullreq_FdtTargetMmcSdhciLib
branch
2 times, most recently
from
ac38c89
to
911cba5
Compare
reg: get values based on reg-names instead of hardcoded indexes interrupts: get values based on interrupt-names instead of hardcoded indexes interrupts: find correct #interrupt-cells used by the sdhci node pinctrl: support new "config" node qcom,bus-speed-mode: clean loop up
feherneoh
force-pushed
the
pullreq_FdtTargetMmcSdhciLib
branch
from
911cba5
to
9551dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reg: get values based on reg-names instead of hardcoded indexes
interrupts: get values based on interrupt-names instead of hardcoded indexes
interrupts: find correct #interrupt-cells used by the sdhci node
pinctrl: support new "config" node
qcom,bus-speed-mode: clean loop up