Catch more OSErrors
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #80 +/- ##
========================================
Coverage 98.43% 98.43%
========================================
Files 4 4
Lines 256 256
========================================
Hits 252 252
Misses 4 4 ☔ View full report in Codecov by Sentry. |
noah-weingarden
changed the title
OSErrors
noah-weingarden
force-pushed
the
add-back-OSError
branch
from
1d4e8ab to
ac60215
Compare
|
Good catch. This reminded me of #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably catch
OSErrors in all places where we usesubprocess.run()instead of justis_executable(). I originally thought we were already doing it and lost it in a merge conflict, but we never were in the first place.