Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced specificity on Redux rependency #62

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Reduced specificity on Redux rependency #62

merged 1 commit into from
Oct 18, 2024

Conversation

rijuma
Copy link
Member

@rijuma rijuma commented Oct 18, 2024

This update is related with issue openedx/frontend-app-learning#1482: Reducing specificity in redux peer dependency allows more flexibility on fontend-app-learning to update it.

@rijuma rijuma marked this pull request as ready for review October 18, 2024 12:08
schenedx
schenedx reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

schenedx
schenedx approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rijuma rijuma merged commit f3b9931 into main Oct 18, 2024
5 checks passed
@rijuma rijuma deleted the rijuma/reduce-specificity-on-redux-dependency branch October 18, 2024 13:45
@bradenmacdonald
Copy link
Member

@rijuma @schenedx Thanks for this! However, this doesn't seem to have solved the issue. Could you please review #63 , which should do the trick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schenedx schenedx schenedx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rijuma @bradenmacdonald @schenedx