Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove marketing promo code #9

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: remove marketing promo code #9

merged 1 commit into from
Apr 16, 2024

Conversation

ahtesham-quraish
Copy link
Contributor

@ahtesham-quraish ahtesham-quraish commented Apr 8, 2024 •
edited
Loading

Description

  • Remove marketing promo from base container
  • We will decide the about the vertical scroll should come or not when Alena provides the exact dimensions

JIRA

VAN-1906

How Has This Been Tested?

Its has been tested locally.

Screenshots:

Before After
image image

mubbsharanwar

This comment was marked as resolved.

Sign in to view

zainab-amir
zainab-amir reviewed Apr 9, 2024
View reviewed changes
src/base-container/index.scss Outdated
Comment on lines 11 to 12
border-top-right-radius: 50% !important;
border-top-left-radius: 50% !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

@ahtesham-quraish ahtesham-quraish Apr 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I have modified the style of cross icon in which I had to change the border style to make it exactly like design but now I have changed the css of cross icon to some thing different so we don't need this. I have removed this.

mubbsharanwar
mubbsharanwar reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@mubbsharanwar mubbsharanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the background color of the modal now? I think it's light-700 should it not be the light-200 mentioned in the ticket?

src/base-container/index.scss Outdated Show resolved Hide resolved
fix: remove marketing promo code
5028d1b 
Description:
Remove marketing promo from base container
VAN-1906
@ahtesham-quraish
Copy link
Contributor Author

What is the background color of the modal now? I think it's light-700 should it not be the light-200 mentioned in the ticket?

I have changed the bg color now to light-200

zainab-amir
zainab-amir reviewed Apr 15, 2024
View reviewed changes
Copy link
Contributor

@zainab-amir zainab-amir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Have an account through ..." text seems to be going on next line. Is it because of the different in font size for current vs future paragon theme?

@ahtesham-quraish
Copy link
Contributor Author

ahtesham-quraish commented Apr 15, 2024 •
edited
Loading

The "Have an account through ..." text seems to be going on next line. Is it because of the different in font size for current vs future paragon theme?

I have changed the font-size and text came in one line, my assumption is it would be fixed in future version of paragon

image

@ahtesham-quraish ahtesham-quraish merged commit e05d796 into master Apr 16, 2024
5 checks passed
@ahtesham-quraish ahtesham-quraish deleted the ahtesham/van-1906 branch April 16, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syedsajjadkazmii syedsajjadkazmii syedsajjadkazmii left review comments

@mubbsharanwar mubbsharanwar mubbsharanwar approved these changes

@zainab-amir zainab-amir zainab-amir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahtesham-quraish @zainab-amir @syedsajjadkazmii @mubbsharanwar