Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement registration happy path #6

Closed
wants to merge 2 commits into from
Closed

feat: implement registration happy path #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f21f8c
feat: desgin registration form pop up
attiyaIshaque Apr 1, 2024
6609703
feat: implement registration happy path
syedsajjadkazmii Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,11 @@ module.exports = createConfig('eslint', {
},
},
],
'no-param-reassign': ['error', {
props: true,
ignorePropertyModificationsFor: [
'state',
],
}],
Comment on lines +44 to +49
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since RTK provides the facility to directly mutate the state object in slice, the ESLint gives error ESLint: Assignment to property of function parameter 'state'.(no-param-reassign). To suppress that error, we are ignoring assignment to state variable.

},
});
5 changes: 2 additions & 3 deletions example/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,11 @@ import { AppProvider } from '@edx/frontend-platform/react';
import { initialize, subscribe, APP_READY } from '@edx/frontend-platform';

import './index.scss';
import AuthnComponent from "../src/authn-component";

subscribe(APP_READY, () => {
ReactDOM.render(
<AppProvider>
<div>Load the forms here</div>
</AppProvider>,
<AuthnComponent setOpen={()=>{}} open={true} />,
document.getElementById('root'),
);
});
Expand Down
Loading
Loading