Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: design for forgot password and reset password #14

Merged
merged 1 commit into from
May 13, 2024
Merged

feat: design for forgot password and reset password #14

merged 1 commit into from
May 13, 2024

Conversation

attiyaIshaque
Copy link
Member

@attiyaIshaque attiyaIshaque commented Apr 24, 2024 •
edited
Loading

Description

  • Design forgot password, forgot password confirmation, and reset password popups.

JIRA

VAN-1920

How Has This Been Tested?

It has been tested locally

Screenshots:

Screenshot 2024-04-24 at 3 39 20 PMScreenshot 2024-04-24 at 3 46 19 PM
Screenshot 2024-04-24 at 3 59 50 PM
Screenshot 2024-04-24 at 4 01 20 PM
Screenshot 2024-04-24 at 4 01 30 PM

@attiyaIshaque attiyaIshaque force-pushed the attiya/VAN-1920-forgot-password branch 2 times, most recently from 2f0fe86 to 3ded298 Compare April 24, 2024 11:03
syedsajjadkazmii
syedsajjadkazmii reviewed Apr 25, 2024
View reviewed changes
src/forms/fields/email-field/index.jsx Show resolved Hide resolved
src/forms/fields/password-field/index.jsx Outdated Show resolved Hide resolved
src/forms/fields/password-field/index.jsx Outdated Show resolved Hide resolved
src/forms/fields/password-field/index.jsx Outdated Show resolved Hide resolved
src/forms/fields/password-field/index.jsx Outdated Show resolved Hide resolved
src/forms/reset-password-popup/reset-password/ResetPasswordPage.jsx Outdated Show resolved Hide resolved
src/forms/reset-password-popup/reset-password/ResetPasswordPage.jsx Outdated Show resolved Hide resolved
src/forms/reset-password-popup/reset-password/ResetPasswordPage.jsx Outdated Show resolved Hide resolved
src/forms/reset-password-popup/reset-password/ResetPasswordPage.jsx Outdated Show resolved Hide resolved
src/forms/reset-password-popup/reset-password/ResetPasswordPage.jsx Show resolved Hide resolved
@attiyaIshaque attiyaIshaque force-pushed the attiya/VAN-1920-forgot-password branch 3 times, most recently from 22f5e06 to 64e0d15 Compare April 30, 2024 08:01
@attiyaIshaque attiyaIshaque marked this pull request as ready for review April 30, 2024 09:58
@attiyaIshaque attiyaIshaque force-pushed the attiya/VAN-1920-forgot-password branch from 64e0d15 to b7c02aa Compare April 30, 2024 10:39
syedsajjadkazmii
syedsajjadkazmii reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docstrings to all the newly created components. Thanks

@attiyaIshaque attiyaIshaque force-pushed the attiya/VAN-1920-forgot-password branch 2 times, most recently from 54a0fb6 to 2cbb274 Compare May 8, 2024 08:09
@attiyaIshaque attiyaIshaque force-pushed the attiya/VAN-1920-forgot-password branch 2 times, most recently from bff018e to cc77601 Compare May 9, 2024 10:46
syedsajjadkazmii
syedsajjadkazmii reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments. thankyou

src/forms/reset-password-popup/forgot-password/ForgotPasswordEmailSentConfirmation.jsx Show resolved Hide resolved
src/forms/reset-password-popup/forgot-password/ForgotPasswordEmailSentConfirmation.jsx Outdated Show resolved Hide resolved
src/forms/reset-password-popup/forgot-password/ForgotPasswordEmailSentConfirmation.jsx Outdated Show resolved Hide resolved
src/forms/reset-password-popup/index.scss Outdated Show resolved Hide resolved
src/forms/reset-password-popup/reset-password/ResetPasswordPage.jsx Outdated Show resolved Hide resolved
src/index.scss Show resolved Hide resolved
@attiyaIshaque attiyaIshaque force-pushed the attiya/VAN-1920-forgot-password branch 2 times, most recently from 7f62a63 to 124a7ed Compare May 13, 2024 06:27
@attiyaIshaque attiyaIshaque force-pushed the attiya/VAN-1920-forgot-password branch from 124a7ed to bdbf18e Compare May 13, 2024 06:50
syedsajjadkazmii
syedsajjadkazmii approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comment before merging

src/forms/reset-password-popup/forgot-password/ForgotPasswordPage.jsx Outdated Show resolved Hide resolved
@attiyaIshaque attiyaIshaque force-pushed the attiya/VAN-1920-forgot-password branch from bdbf18e to efe52f5 Compare May 13, 2024 07:57
mubbsharanwar
mubbsharanwar approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@mubbsharanwar mubbsharanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comment before merging the PR.

src/forms/fields/email-field/index.jsx Outdated Show resolved Hide resolved
@attiyaIshaque attiyaIshaque force-pushed the attiya/VAN-1920-forgot-password branch from efe52f5 to 122df6b Compare May 13, 2024 09:47
@attiyaIshaque attiyaIshaque merged commit 3b300cd into master May 13, 2024
5 checks passed
@attiyaIshaque attiyaIshaque deleted the attiya/VAN-1920-forgot-password branch May 13, 2024 10:04
@attiyaIshaque attiyaIshaque restored the attiya/VAN-1920-forgot-password branch May 14, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mubbsharanwar mubbsharanwar mubbsharanwar approved these changes

@syedsajjadkazmii syedsajjadkazmii syedsajjadkazmii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@attiyaIshaque @syedsajjadkazmii @mubbsharanwar