Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add unit tests for different modules to improve coverage #127

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

attiyaIshaque
Copy link
Member

@attiyaIshaque attiyaIshaque commented Aug 2, 2024

Description

In this PR, I have added tests for the registration reducer and service, and login files which has slightly increased our coverage.

JIRA

VAN-2001

How Has This Been Tested?

Mention any tests you've added or updated to ensure the changes work as expected.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After
Screenshot 2024-08-02 at 2 57 52 PM Screenshot 2024-08-02 at 2 59 17 PM

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

@attiyaIshaque attiyaIshaque force-pushed the attiya/add-registration-test branch from 2c926f8 to 524c01a Compare August 2, 2024 12:50
@attiyaIshaque attiyaIshaque force-pushed the attiya/add-registration-test branch 2 times, most recently from 8f1ff13 to 2806c43 Compare August 20, 2024 14:45
@attiyaIshaque attiyaIshaque changed the title fix: add tests for registration reducer and service fix: add unit tests for different modules to improve coverage Aug 21, 2024
@attiyaIshaque attiyaIshaque force-pushed the attiya/add-registration-test branch from 2806c43 to 6fae198 Compare August 27, 2024 10:50
@attiyaIshaque attiyaIshaque merged commit 7f2689c into master Aug 28, 2024
5 checks passed
@attiyaIshaque attiyaIshaque deleted the attiya/add-registration-test branch August 28, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants