fix: update payload property (#104)

edx · Jul 4, 2024 · 75e0195 · 75e0195
1 parent 5c6b646
commit 75e0195
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/src/forms/registration-popup/data/reducers.js b/src/forms/registration-popup/data/reducers.js
@@ -16,7 +16,7 @@ export const registerInitialState = {
   validationState: DEFAULT_STATE,
   registrationError: {},
   registrationResult: {},
-  registrationFields: { marketingEmailOptIn: true },
+  registrationFields: { marketingEmailsOptIn: true },
   userPipelineDataLoaded: false,
   validationApiRateLimited: false,
   validations: null,

diff --git a/src/forms/registration-popup/index.jsx b/src/forms/registration-popup/index.jsx
@@ -61,7 +61,7 @@ const RegistrationForm = () => {
   const [formStartTime, setFormStartTime] = useState(null);
 
   const [formFields, setFormFields] = useState({
-    name: '', email: '', password: '', marketingEmailOptIn: true,
+    name: '', email: '', password: '', marketingEmailsOptIn: true,
   });
   const [errors, setErrors] = useState({});
   const [errorCode, setErrorCode] = useState({ type: '', count: 0 });
@@ -103,7 +103,7 @@ const RegistrationForm = () => {
     if (!userPipelineDataLoaded && thirdPartyAuthApiStatus === COMPLETE_STATE) {
       if (thirdPartyAuthErrorMessage) {
         setErrorCode(prevState => ({ type: TPA_AUTHENTICATION_FAILURE, count: prevState.count + 1 }));
-        localStorage.removeItem('marketingEmailOptIn');
+        localStorage.removeItem('marketingEmailsOptIn');
         localStorage.removeItem('ssoPipelineRedirectionDone');
       }
       if (pipelineUserDetails && Object.keys(pipelineUserDetails).length !== 0) {
@@ -149,8 +149,8 @@ const RegistrationForm = () => {
     if (registrationError[name]) {
       dispatch(clearRegistrationBackendError(name));
     }
-    // seting marketingEmailOptIn state for SSO authentication flow for register API call
-    if (name === 'marketingEmailOptIn') {
+    // seting marketingEmailsOptIn state for SSO authentication flow for register API call
+    if (name === 'marketingEmailsOptIn') {
       dispatch(setRegistrationFields({ [name]: value }));
     }
     setErrors(prevErrors => ({ ...prevErrors, [name]: '' }));
@@ -163,14 +163,14 @@ const RegistrationForm = () => {
       && localStorage.getItem('ssoPipelineRedirectionDone')
     ) {
       localStorage.removeItem('ssoPipelineRedirectionDone');
-      localStorage.removeItem('marketingEmailOptIn');
+      localStorage.removeItem('marketingEmailsOptIn');
     }
   }, [currentProvider, thirdPartyAuthApiStatus]);
 
   useEffect(() => {
     if (registrationResult.success) {
       // clear local storage
-      localStorage.removeItem('marketingEmailOptIn');
+      localStorage.removeItem('marketingEmailsOptIn');
       localStorage.removeItem('ssoPipelineRedirectionDone');
 
       // This event is used by GTM
@@ -220,8 +220,8 @@ const RegistrationForm = () => {
       payload.social_auth_provider = currentProvider;
 
       if (!isLoginSSOIntent) {
-        delete payload.marketingEmailOptIn;
-        payload.marketingEmailOptIn = localStorage.getItem('marketingEmailOptIn');
+        delete payload.marketingEmailsOptIn;
+        payload.marketingEmailsOptIn = localStorage.getItem('marketingEmailsOptIn');
       }
     }
 
@@ -343,8 +343,8 @@ const RegistrationForm = () => {
                 />
               )}
               <MarketingEmailOptInCheckbox
-                name="marketingEmailOptIn"
-                value={formFields.marketingEmailOptIn}
+                name="marketingEmailsOptIn"
+                value={formFields.marketingEmailsOptIn}
                 handleChange={handleOnChange}
               />
               <div className="d-flex flex-column my-4">

diff --git a/src/forms/registration-popup/tests/RegistrationPopup.test.jsx b/src/forms/registration-popup/tests/RegistrationPopup.test.jsx
@@ -93,7 +93,7 @@ describe('RegistrationForm Test', () => {
       email: '[email protected]',
       name: 'test',
       password: 'test-password12',
-      marketing_email_opt_in: true,
+      marketing_emails_opt_in: true,
       honor_code: true,
       terms_of_service: true,
       total_registration_time: 0,
@@ -127,7 +127,7 @@ describe('RegistrationForm Test', () => {
       email: '[email protected]',
       name: 'test',
       password: 'test-password12',
-      marketing_email_opt_in: true,
+      marketing_emails_opt_in: true,
       honor_code: true,
       terms_of_service: true,
       country: 'US',