Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up world map loading #151

Merged
merged 32 commits into from
May 24, 2024
Merged

Speed up world map loading #151

merged 32 commits into from
May 24, 2024

Conversation

edwardchalstrey1
Copy link
Owner

@edwardchalstrey1 edwardchalstrey1 commented May 24, 2024 •
edited
Loading

Closes #124

  • Extend shapesData instead of replacing it
  • Load a single polity first on the world map so it loads faster
  • Adds an id field to Videoshapefile model

TODO:

  • Check tests
  • Refactor map views to avoid duplicate code

@edwardchalstrey1
add to existing shapesData
f28af7e
@edwardchalstrey1
add id primary key to VideoShapefile
1e57c4a
@edwardchalstrey1
Refactor world_map.html to add missing shapes to shapesData by ignori…
dfca4fd 
…ng those with a shape.id already there
@edwardchalstrey1
add id to get_polity_shape_content
48efffb
@edwardchalstrey1
filter properly using string conversion
a6a7c03
@edwardchalstrey1
Merge branch 'dev' into extend-shapesData
18c73b7
@edwardchalstrey1
rename polityMapShapesData
cc71e70
@edwardchalstrey1
load just british empire II first
83423e8
@edwardchalstrey1
use polityBorderWeightSelected
5cfae14
@edwardchalstrey1
set the initial year and polity and highlight it by default
9eae6a4
@edwardchalstrey1
always redirect
8160a61
@edwardchalstrey1
remove page reload
e2d8214
@edwardchalstrey1
remove page reload
7127c96
@edwardchalstrey1
only set end year to 2014 if it's more recent for initial view
d862055
@edwardchalstrey1
update loading text
43fe853
@edwardchalstrey1
make rome default
8d9020b
@edwardchalstrey1
ungrey play buttons
665a046
@edwardchalstrey1
add space
01b2381
@edwardchalstrey1
order shapes by start year
51401df
@edwardchalstrey1
remove legacy button enabling
db14c59
@edwardchalstrey1
load shapes for one year as well
073ab84
@edwardchalstrey1
handle shape.id as int
fcaa1ba
@edwardchalstrey1
dont update date slide for world_map_one_year
42b0f79
@edwardchalstrey1
enable adding to legend in advance of all polities loading
b43b70b
@edwardchalstrey1
pick a random polity
3ae638b
@edwardchalstrey1
random polity (with seshat id) as initial loaded works
edbef64
@edwardchalstrey1
keep defaults
492ae3e
@edwardchalstrey1 edwardchalstrey1 changed the title Extend shapes data Speed up world map loading May 24, 2024
@edwardchalstrey1 edwardchalstrey1 merged commit b093ccb into dev May 24, 2024
1 check passed
@edwardchalstrey1 edwardchalstrey1 deleted the extend-shapesData branch May 24, 2024 11:26
edwardchalstrey1 added a commit that referenced this pull request Jun 25, 2024
@edwardchalstrey1
Merge pull request #151 from edwardchalstrey1/extend-shapesData
4750f38 
Speed up world map loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase efficiency of shape loading on Seshat VM *before 29th June*
1 participant
@edwardchalstrey1