Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move end years code generation to Cliopatria #156

Closed
7 tasks done
edwardchalstrey1 opened this issue Jun 3, 2024 · 1 comment · Fixed by Seshat-Global-History-Databank/seshat#22
Closed
7 tasks done
Assignees

Comments

@edwardchalstrey1
Copy link
Owner

edwardchalstrey1 commented Jun 3, 2024

The populate_videodata command script has a part where we generate end years for each shape, based on some logic involving the start year and the years in the name_years.json - it might be better to forward this to Jim Bennett/ Cliopatria team for them to use to add a field for the end_year to each shape, meaning that we'd only need a single GeoJSON for Cliopatria, and the command script could also be simplified

TODO

  • Write a script that does the above - see Add Cliopatria viewer notebook #167
  • Send to Jim et al
  • Should we just use the colours in the dataset? How are these being generated?
  • Update Cliopatria loading script to support 07052024 version Seshat-Global-History-Databank/seshat#19
  • Once Cliopatria has end years included, update the populate_videodata command script
  • Make the populate_videodata command script accept a single geojson file and update rst doc to reflect this
  • There is a problem with using GeoPandas as part of the populate_videodata command script in that it causes a segmentation fault (this is something to do with conflict between Geopandas and GEOS). Instead, move the function that converts the geoJSON in geopandas by adding extra fields to a new conversion script that spits out a new GeoJSON. This can then be loaded much more quickly by the webapp and notebook since the colours are already generated
    • Make the Cliopatria notebook and the command script use the exact same code - call it the cliopatria handling module
@edwardchalstrey1
Copy link
Owner Author

Update: Jim is incorporating this into the Seshat code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant