Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Cliopatria loading and visualiser notebook #22

Merged
merged 77 commits into from
Jul 12, 2024

Conversation

edwardchalstrey1
Copy link

@edwardchalstrey1 edwardchalstrey1 commented Jul 10, 2024

Copy link
Member

@kallewesterling kallewesterling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - I just think we need to add some docstrings in, to make sure that we've future-proofed the code a little bit!

docs/source/getting-started/setup/spatialdb.rst Outdated Show resolved Hide resolved
docs/source/getting-started/setup/spatialdb.rst Outdated Show resolved Hide resolved
notebooks/map_functions.py Show resolved Hide resolved
notebooks/map_functions.py Show resolved Hide resolved
notebooks/map_functions.py Show resolved Hide resolved
notebooks/map_functions.py Show resolved Hide resolved
seshat/apps/core/models.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@MajidBenam MajidBenam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes seem good to me. I am enjoying (still learning) this new style of collaboration.

@kallewesterling
Copy link
Member

Looks good to me!

@edwardchalstrey1 edwardchalstrey1 merged commit fb4573c into dev Jul 12, 2024
2 checks passed
@edwardchalstrey1 edwardchalstrey1 deleted the cliopatria-end-years branch July 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants