Fix converting (all) properties to TFX Properties #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know why, but removing the whitespace will sometimes result in an endless loop always getting a new PsiWhitespace object. nullable primitive objects need to be SimpleObjectProperties as the primitive counterpart do not support null. Lastly, disable "convert all properties to TFX properties" in data classes as that would result in an empty constructor which is not allowed for data classes. It would break the data classes functions anyway. We might want to consider improving the intention action to keep constructor parameters so the user of that class can create an object in the same way it was before running this action. Right now we remove the parameters. I still think it's wrong for data classes though fixes edvin#96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why, but removing the whitespace will sometimes result
in an endless loop always getting a new PsiWhitespace object.
nullable primitive objects need to be SimpleObjectProperties as
the primitive counterpart do not support null.
Lastly, disable "convert all properties to TFX properties" in data classes
as that would result in an empty constructor which is not allowed
for data classes. It would break the data classes functions anyway.
We might want to consider improving the intention action to keep
constructor parameters so the user of that class can create an object
in the same way it was before running this action. Right now we remove the
parameters.
I still think it's wrong for data classes though
fixes #96