Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility edit #221

Open
wants to merge 9 commits into
base: digitdustin/restyling
Choose a base branch
from
Open

Conversation

MatthewJung14
Copy link
Contributor

Added various minor changes in order to improve the user accessibility of Edugator. See the document below for the details about the changes I made and about more accessibility information.

https://docs.google.com/document/d/1jAOFltlPVQ1i_v122Lu2FN7fZZ5LUCn3RoAIrGrERo8/edit

@vercel
Copy link

vercel bot commented Mar 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
edugator-staff-frontend ❌ Failed (Inspect) Mar 25, 2023 at 4:06PM (UTC)

Copy link
Contributor

@kapooramanpreet kapooramanpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks is good to me.

pages/code/index.tsx Outdated Show resolved Hide resolved
@@ -89,7 +89,7 @@ const ContentSidebar = ({
{toggleExercisesLinks.map((link) => (
<Tabs.Trigger
key={link.id}
className="px-3 py-3 transition data-[state=active]:border-b data-[state=inactive]:border-b-slate-400 data-[state=active]:border-b-emerald-500 flex-1 flex items-center justify-center text-sm font-dm leading-none text-slate-500 select-none hover:text-white data-[state=active]:text-white outline-none cursor-default"
className="px-3 py-3 transition data-[state=active]:border-b data-[state=inactive]:text-white border-b-slate-500 data-[state=active]:border-b-emerald-400 flex-1 flex items-center justify-center text-sm font-dm leading-none text-slate-500 select-none hover:bg-blue-500/10 data-[state=active]:text-white outline-none cursor-default"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be reviewed by @digitdustin

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@kapooramanpreet kapooramanpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with this. Let Dustin review this and then you can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants