Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back end routes #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

marcgabe15
Copy link
Contributor

This PR adds in the back end routes for edugator v2 series with multi class integration. This is written in OpenAPI 3.1
For seeing the UI configuration, go to https://editor.swagger.io/ and import said yaml file

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Copy link
Contributor

@kapooramanpreet kapooramanpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Marc. A few minor changes are needed.

description: This is backend api for edugator https://github.com/edugator-cise/edugator-staff-backend
contact:
email: [email protected]
license:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to:

  license:
    name: GNU v0.3
    url: https://www.gnu.org/licenses/gpl-3.0.en.html
  version: 2.0.0

url: http://swagger.io
servers:
- url: https://edugator-admin.com/v2
- url: https://edugator-admin.com/v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are there two server urls?

schema:
type: object
properties:
exp:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is exp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expiration time

- submissionId
- submissionType
- timeOfSubmission
- score
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the schema should also contain the submission itself in the form of an object. For example, if a student submits code, the actual code as well as the feedback generated at the time of submission.

post:
tags:
- submission
summary: creates a submission
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need a delete for the submission. There will be a delete course option that deletes all submissions or the user can delete their data.

post:
tags:
- user
summary: adds a course to a user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change summary to "adds a user to a course".

SubmissionEvent:
required:
- userId
- courseId
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this course id should be problem/lesson id as an event is associated with a problem/lesson rather than a course.

score:
type: integer
ProblemWithoutId:
required:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think each problem will have a link ID (url) for mapping it to Canvas. this should be optional but can be added to the schema

get:
tags:
- problem
summary: Gets all the non hidden problems for COP3530 course given module id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean all cop3530 to "a course"; repeat for all summaries.

type: array
items:
$ref: '#/components/schemas/Problem'
/problem:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename the problem routes to something else - as we have two types now: lessons vs coding problems. Or there should be some means to distinguish the two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants